Open
Conversation
Alessandro-Barbieri
force-pushed
the
spell-crit
branch
from
36143c0 to
a9bcaca
Compare
BreakBB
reviewed
Feb 13, 2026
| local setBonus = _SpellCrit:GetSetBonus(school) | ||
|
|
||
| if ECS.IsWotlk then | ||
| crit = crit + GetCombatRatingBonus(CR_CRIT_SPELL) + GetSpellCritChanceFromIntellect("player") + itemBonus + setBonus |
Owner
There was a problem hiding this comment.
Can you share any information why you removed this? Did you verify it in WotLK or something?
Ah it seems GetSpellCritChance returns the same as GetCombatRatingBonus(CR_CRIT_SPELL) + GetSpellCritChanceFromIntellect("player")
Contributor
Author
There was a problem hiding this comment.
Can you share any information why you removed this? Did you verify it in WotLK or something?
No
Ah it seems
GetSpellCritChancereturns the same asGetCombatRatingBonus(CR_CRIT_SPELL) + GetSpellCritChanceFromIntellect("player")
Yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.