Fix CancellationTokenSource leak in ViewModels#3448
Merged
Conversation
Dispose the previous CancellationTokenSource before overwriting it in IPScanner, PortScanner, Traceroute, PingMonitor, PingMonitorHost and SNMP. Each Start() created a new instance without disposing the old one, leaking the WaitHandle allocated by CancellationTokenSource on every run. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a resource leak in several WPF ViewModels by disposing the previous CancellationTokenSource before creating a new one on each run, preventing WaitHandle accumulation across repeated Start/Stop cycles.
Changes:
- Added
_cancellationTokenSource?.Dispose();immediately before reassigning a newCancellationTokenSourcein multiple ViewModels. - Applied the same pattern consistently across scanner/monitor/traceroute/SNMP workflows.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Source/NETworkManager/ViewModels/TracerouteViewModel.cs | Dispose previous CTS before starting a new traceroute run. |
| Source/NETworkManager/ViewModels/SNMPViewModel.cs | Dispose previous CTS before starting a new SNMP operation. |
| Source/NETworkManager/ViewModels/PortScannerViewModel.cs | Dispose previous CTS before starting a new port scan. |
| Source/NETworkManager/ViewModels/PingMonitorViewModel.cs | Dispose previous CTS before starting ping monitoring for a host. |
| Source/NETworkManager/ViewModels/PingMonitorHostViewModel.cs | Dispose previous CTS before starting host-resolution/add workflow in Ping Monitor Host view. |
| Source/NETworkManager/ViewModels/IPScannerViewModel.cs | Dispose previous CTS before starting a new IP scan. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+505
to
507
| _cancellationTokenSource?.Dispose(); | ||
| _cancellationTokenSource = new CancellationTokenSource(); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CancellationTokenSourcebefore overwriting it inIPScannerViewModel,PortScannerViewModel,TracerouteViewModel,PingMonitorViewModel,PingMonitorHostViewModel, andSNMPViewModelStart()call created a newCancellationTokenSourcewithout disposing the previous instance, leaking the underlyingWaitHandleon every run_cancellationTokenSource?.Dispose()line before each reassignment — safe becauseCanExecuteguards ensureIsRunningis false beforeStart()is called againTest plan
🤖 Generated with Claude Code