Feature: Profile file creation enhancements#3227
Merged
mergify[bot] merged 4 commits intomainfrom Nov 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors dialog handling for profile files, migrating from CustomDialog to ChildWindow pattern, standardizes event handler naming to use the _OnLoaded suffix, and upgrades the WixToolset SDK to version 6.0.2.
- Converts async void event handlers to async Task methods with proper command binding
- Refactors ProfileFileDialog from UserControl to ProfileFileChildWindow (ChildWindow)
- Adds new encryption prompt when creating profile files
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| WelcomeChildWindow.xaml.cs/.xaml | Renames event handler from ChildWindow_Loaded to ChildWindow_OnLoaded |
| UpgradeChildWindow.xaml.cs/.xaml | Renames event handler from ChildWindow_Loaded to ChildWindow_OnLoaded |
| ProfileFileDialog.xaml.cs | Removes old UserControl-based dialog code |
| ProfileFileChildWindow.xaml.cs/.xaml | Adds new ChildWindow-based dialog implementation with consistent naming |
| OKMessageChildWindow.xaml.cs/.xaml | Renames event handler and removes extra whitespace |
| OKCancelInfoMessageChildWindow.xaml.cs/.xaml | Renames event handler from ChildWindow_Loaded to ChildWindow_OnLoaded |
| SettingsProfilesViewModel.cs | Converts methods from async void to async Task, migrates from CustomDialog to ChildWindow pattern, adds encryption prompt for new profiles |
| NETworkManager.Setup.wixproj | Upgrades WixToolset SDK from 5.0.0 to 6.0.2 |
| Strings.resx/Designer.cs | Removes DeleteProfileFileMessage, adds DeleteProfileFileXMessage, EnableEncryptionQuestion, and EnableEncryptionForProfileFileMessage resources |
| GlobalAssemblyInfo.cs | Updates assembly version from 2025.10.18.0 to 2025.11.1.0 |
Files not reviewed (1)
- Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
{generated summary}
To-Do
Contributing
By submitting this pull request, I confirm the following: