Fix: Profile filter dialog closing when putty/powershell console is open#3222
Merged
mergify[bot] merged 3 commits intomainfrom Oct 31, 2025
Merged
Fix: Profile filter dialog closing when putty/powershell console is open#3222mergify[bot] merged 3 commits intomainfrom
mergify[bot] merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
ToDo:
Related issue(s)
Copilot generated summary
Provide a Copilot generated summary of the changes in this pull request.
Copilot summary
This pull request introduces a new mechanism for tracking the open/closed state of the profile filter popup and ensures that the popup remains open under appropriate conditions. It adds a new property to the configuration, updates logic to check this state before focusing embedded windows, and hooks up the popup's close event to update the state accordingly. Additionally, a bug fix is documented for the popup closing unexpectedly when certain sessions were opened.
Profile Filter Popup State Management:
IsProfileFilterPopupOpentoConfigurationInfo.csto track whether the profile filter popup is open.FocusEmbeddedWindow()logic inMainWindow.xaml.csto checkIsProfileFilterPopupOpenbefore focusing an embedded window, preventing unintended focus changes when the popup is open.IsProfileFilterPopupOpentotruewhen opening the profile filter inPowerShellHostViewModel.cs, and added an event handler to set it tofalsewhen the popup is closed. [1] [2]UI Event Handling:
Closedevent for the profile filter popup inPowerShellHostView.xaml, and implemented the corresponding event handler inPowerShellHostView.xaml.csto update the popup state. [1] [2]Documentation:
To-Do
Contributing
By submitting this pull request, I confirm the following: