Skip to content

Fix: Profile filter dialog closing when putty/powershell console is open#3222

Merged
mergify[bot] merged 3 commits intomainfrom
fix/3219
Oct 31, 2025
Merged

Fix: Profile filter dialog closing when putty/powershell console is open#3222
mergify[bot] merged 3 commits intomainfrom
fix/3219

Conversation

@BornToBeRoot
Copy link
Owner

@BornToBeRoot BornToBeRoot commented Oct 28, 2025

Changes proposed in this pull request

  • Profile filter dialog closing when putty/powershell console is open

ToDo:

  • PowerShell
  • PuTTY
  • AWS Session Manager

Related issue(s)

Copilot generated summary

Provide a Copilot generated summary of the changes in this pull request.

Copilot summary

This pull request introduces a new mechanism for tracking the open/closed state of the profile filter popup and ensures that the popup remains open under appropriate conditions. It adds a new property to the configuration, updates logic to check this state before focusing embedded windows, and hooks up the popup's close event to update the state accordingly. Additionally, a bug fix is documented for the popup closing unexpectedly when certain sessions were opened.

Profile Filter Popup State Management:

  • Added a new property IsProfileFilterPopupOpen to ConfigurationInfo.cs to track whether the profile filter popup is open.
  • Updated FocusEmbeddedWindow() logic in MainWindow.xaml.cs to check IsProfileFilterPopupOpen before focusing an embedded window, preventing unintended focus changes when the popup is open.
  • Set IsProfileFilterPopupOpen to true when opening the profile filter in PowerShellHostViewModel.cs, and added an event handler to set it to false when the popup is closed. [1] [2]

UI Event Handling:

  • Hooked up the Closed event for the profile filter popup in PowerShellHostView.xaml, and implemented the corresponding event handler in PowerShellHostView.xaml.cs to update the popup state. [1] [2]

Documentation:

  • Added a changelog entry documenting the bug fix for the profile filter popup closing unexpectedly when certain sessions were opened.

To-Do

Contributing

By submitting this pull request, I confirm the following:

@mergify mergify bot merged commit 0ef298e into main Oct 31, 2025
4 checks passed
@mergify mergify bot deleted the fix/3219 branch October 31, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot open profile filter dialog when a console (pwsh/putty) is connected

1 participant