Open
Conversation
asmsuechan
approved these changes
Mar 23, 2018
Contributor
asmsuechan
left a comment
There was a problem hiding this comment.
Hi, @narukami894. Sorry for my long absence and thank you very much for your improvement!
LGTM
Contributor
|
GOSH. I don't have merge authorization... |
Member
|
@asmsuechan I've invited you as an admin to this repository. Check your e-mail. 😄 |
|
@opengift-io has started working. Visit this issue on Issuehunt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thank you for creating nice app and import tool!
I fixed
json_generator.rbto buildboostnote.jsonas same as Boostnote itself by usingJSON.pretty_generate, and replace the order of json keys.before:
after: