Skip to content

Fix Vim Ctrl-C copy shortcut #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dicnunz wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −8
Open

Fix Vim Ctrl-C copy shortcut #1672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 32 additions & 8 deletions src/cloud/lib/editor/components/CodeMirrorEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,33 @@ interface EditorProps {
onYTextChange?: (event: YEvent, ytext: YText) => void
}

const defaultExtraKeys: CodeMirror.KeyMap = {
Enter: 'newlineAndIndentContinueMarkdownList',
Tab: 'indentMore',
'Ctrl-C': (cm: CodeMirror.Editor) => {
if (cm.getOption('keyMap') === 'vim') {
document.execCommand('copy')
}
return CodeMirror.Pass
},
}

function buildEditorConfig(
config: CodeMirror.EditorConfiguration
): CodeMirror.EditorConfiguration {
if (typeof config.extraKeys === 'string') {
return config
}

return {
...config,
extraKeys: {
...defaultExtraKeys,
...config.extraKeys,
},
}
}

const CodeMirrorEditor = ({
config = {},
realtime,
Expand All @@ -35,13 +62,10 @@ const CodeMirrorEditor = ({

useEffectOnce(() => {
if (editorRootRef.current != null) {
editorRef.current = CodeMirror(editorRootRef.current, {
extraKeys: {
Enter: 'newlineAndIndentContinueMarkdownList',
Tab: 'indentMore',
},
...config,
})
editorRef.current = CodeMirror(
editorRootRef.current,
buildEditorConfig(config)
)

editorRef.current.on('keydown', (cm, event) => {
if (cm.state.vim && cm.state.vim.insertMode) {
Expand Down Expand Up @@ -76,7 +100,7 @@ const CodeMirrorEditor = ({

useEffect(() => {
if (editorRef.current != null) {
Object.entries(config).forEach(([key, val]) => {
Object.entries(buildEditorConfig(config)).forEach(([key, val]) => {
editorRef.current!.setOption(
key as keyof CodeMirror.EditorConfiguration,
val
Expand Down