Demo video-capture: Crop size to a multiple of two #474
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To accommodate 4:2:0 subsampling, libx264 and libx265 require the video size to be a multiple of two. Add that behavior, with a flag to adjust it in the full demo.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To accommodate 4:2:0 subsampling, libx264 and libx265 require the video size to be a multiple of two. Add that behavior, with a flag to adjust it in the full demo.
See also #472
Changes proposed in this PR
Fixes #
Width and height must be divisible by 2, otherwise the encoder will fail. Round down to the nearest even number.
./check.shpassed