Add a test for tuples that have negative coordinates. #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, a negative width or height. Particularly, this seems like an easy case for a user to hit if somebody forgets that the PIL tuple style uses top, left, RIGHT, BOTTOM and not top, left, WIDTH, HEIGHT. Ask how I know. Test that we do handle that gracefully.
Owner
|
I see macOS and Windows are less strict. Should we add checks in our code instead of relying on the backend to fail? |
Contributor
Author
|
Yeah, I was surprised about that here too! I'll add a test in grab to check the bounds, and make sure it gets invoked in the other paths too. |
I thought I'd seen a test for for invalid regions somewhere before...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, a negative width or height.
Particularly, this seems like an easy case for a user to hit if somebody forgets that the PIL tuple style uses top, left, RIGHT, BOTTOM and not top, left, WIDTH, HEIGHT.
Ask how I know.
Test that we do handle that gracefully.
Changes proposed in this PR
It is very important to keep up to date tests and documentation.
Is your code right?
./check.shpassed