ENH: Replace cmake subprocess tar.gz extraction with zlib in unit tests#1538
Merged
imikejackson merged 1 commit intoBlueQuartzSoftware:developfrom Feb 19, 2026
Conversation
Replace reproc++ cmake subprocess decompression in TestFileSentinel with in-process zlib gzread + manual tar parsing. This removes the cmake executable path dependency from test infrastructure, eliminating k_CMakeExecutable from all test_dirs templates and ~146 test call sites. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
imikejackson
force-pushed
the
topic/use_zlib_for_unit_tests
branch
from
8b10c67 to
035fd3e
Compare
nyoungbq
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace reproc++ cmake subprocess decompression in TestFileSentinel with in-process zlib gzread + manual tar parsing. This removes the cmake executable path dependency from test infrastructure, eliminating k_CMakeExecutable from all test_dirs templates and ~146 test call sites.