Skip to content

Comments

TEST: Test ParameterVersion() and clone() functions of each filter#1531

Merged
imikejackson merged 1 commit intoBlueQuartzSoftware:developfrom
imikejackson:topic/unit_test_parameter_version_clone
Feb 18, 2026
Merged

TEST: Test ParameterVersion() and clone() functions of each filter#1531
imikejackson merged 1 commit intoBlueQuartzSoftware:developfrom
imikejackson:topic/unit_test_parameter_version_clone

Conversation

@imikejackson
Copy link
Contributor

These functions were flagged by GCOV as never having been executed. This unit test will ensure that they get tested.

Copy link
Contributor

@nyoungbq nyoungbq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks fine, although other places in the code call Application::DeleteInstance(); towards the end of test so be sure to validate its getting cleaned up by just exiting scope here. That said, the file structuring is not great. In each of the plugin level clone tests you are loading all the plugins each time, which removes the benefit storing them at the plugin level would normally have. This is an application level test so it should be moved to the simplnx/test folder and consolidated into one file, since each instance already runs every filter from every plugin. Lastly, this is optional as it is more personal preference to prefer existing over new, but there are already application level test files these cases could be moved into. FilterValidationTest.cpp seems like a good candidate to me because it already tests every filters name function in the case at the bottom, and these have a similar structure and intention.

@imikejackson imikejackson force-pushed the topic/unit_test_parameter_version_clone branch from 7a64247 to ea4d365 Compare February 17, 2026 15:05
@imikejackson
Copy link
Contributor Author

@nyoungbq Thank you for the recommendations. I rewrote the test cases inside of the FilterValidationTest.cpp file.

@imikejackson imikejackson force-pushed the topic/unit_test_parameter_version_clone branch from ea4d365 to 065851a Compare February 17, 2026 15:07
@imikejackson imikejackson force-pushed the topic/unit_test_parameter_version_clone branch from 065851a to 859bc07 Compare February 18, 2026 20:04
@imikejackson imikejackson enabled auto-merge (squash) February 18, 2026 20:04
@imikejackson imikejackson merged commit 28a2e1d into BlueQuartzSoftware:develop Feb 18, 2026
6 checks passed
@imikejackson imikejackson deleted the topic/unit_test_parameter_version_clone branch February 18, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants