ENH: Resample Image Geometry uses much less memory at the cost of some computation time#1529
Open
imikejackson wants to merge 4 commits intoBlueQuartzSoftware:developfrom
Open
Conversation
9fae1de to
ab3332f
Compare
Uses ProgressMessageHelper with shared atomic counter to report percentage complete for each DataArray during the resampling loop. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
We cannot parallelize effectively over each array without allocating 8 byte indices or other large buffers so go back to at copying each Data Array on its own thread.
ab3332f to
1b22dfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was updated to remove the pre-calculated voxel indices which added an 8 byte integer at every voxel which can quickly blow up memory usage. The code now uses some extra cpu cycles to compute the source and destination indices.