REV: Compute Grouping Density Filter Review#19
Closed
imikejackson wants to merge 6 commits intodevelopfrom
Closed
Conversation
Contributor
imikejackson
commented
Feb 25, 2026
imikejackson
commented
- Algorithm updated
- Documentation updated
- Unit tests created
- Unit test exemplar file generated and verified.
imikejackson
force-pushed
the
topic/compute_grouping_density_review
branch
2 times, most recently
from
a4a4f32 to
da8e101
Compare
Call the function for the normal neighbor list and optionally call it again for the non-contiguous neighbor list (neighborhood).
- Fix broken fmt::format in preflight error -15672 (missing {} placeholders)
- Rename 10+ variables to follow coding conventions (Ref suffix for
DataStore references, descriptive names for loop vars and parameters)
- Remove commented-out dead code in processNeighborListData
- Fix int32 vs usize type mismatch in processNeighborListData signature
- Make m_NonContiguousNL member const (read-only access)
- Replace std::set with std::unordered_set for O(1) lookups
- Use .contains() consistently instead of .find()==.end()
- Replace redundant getDataAs null checks with getDataRefAs references
- Remove experimental/untested warning now that tests exist
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
imikejackson
force-pushed
the
topic/compute_grouping_density_review
branch
from
da8e101 to
dc62a14
Compare
Contributor
Author
|
Moved to BlueQuartzSoftware/simplnx#1548 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.