Miniexpr for Windows #565
Open
Miniexpr for Windows #565
+48
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lshaw8317
reviewed
Jan 28, 2026
| try: | ||
| res_eval._set_pref_expr(expression, operands, fp_accuracy=fp_accuracy) | ||
| print("expr->miniexpr:", expression, fp_accuracy) | ||
| # print("expr->miniexpr:", expression, fp_accuracy) |
Collaborator
There was a problem hiding this comment.
Should we remove this now that we are doing a release?
| expression_miniexpr = f"{reduce_op_str}({expression})" | ||
| res_eval._set_pref_expr(expression_miniexpr, operands, fp_accuracy, aux_reduc) | ||
| print("expr->miniexpr:", expression, reduce_op, fp_accuracy) | ||
| # print("expr->miniexpr:", expression, reduce_op, fp_accuracy) |
| use_miniexpr = False | ||
| if not (all_ndarray and out is None): | ||
| use_miniexpr = False | ||
| has_complex = any( |
Collaborator
There was a problem hiding this comment.
Could this be wrapped as a function (as it is called twice). Should maybe make it easier in future to get rid of this when windows is working. Maybe call it windows_check or something to make it explicit (I don't think the variables are used for anything else in the code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal modifications for allowing miniexpr to run on windows too. It currently has these limitations:
There has been a considerable amount of effort to reduce the limitations on windows to just this two cases, so I am quite satisfied with what we have now. All other cases, including SIMD accelerations for transcendental functions via SLEEF, are working really well.
Ready for review.