fix: CRLF newline handling and error span rendering#262
fix: CRLF newline handling and error span rendering#262metalurgical wants to merge 1 commit intoBlockstreamResearch:masterfrom
Conversation
40661b5 to
ab4848a
Compare
|
#257 was merged, could you rebase pls Also, have to ask you to narrow down the changes to CRLF only due to the reason that the lexer is limited to the LF/CRLF/CR (\n, \r\n, \r), though I do not see a reason to support CR, as it seems a legacy thing |
|
ab4848a needs rebase |
ab4848a to
ea07842
Compare
Previously, CRLF was treated as two newlines, causing incorrect line numbers, extra blank lines, and misaligned spans on Windows. - treat CRLF as a single newline - use consistent newline handling for line/column calculation and display - fix trailing space rendering on empty lines - preserve UTF-16 column alignment and span rendering
ea07842 to
fcbc7bc
Compare
Has been narrowed to an explicit check instead of via |
|
Need to take a deeper look, there could be an issue with lexer that still uses |
I suspected CR still needed to be handled. So in this instance should it be erased or treated as a newline? |
Previously, CRLF was treated as two newlines, causing incorrect line numbers, extra blank lines, and misaligned spans on Windows.