testing: Remove obsolete test_lsp_jit_fee test#721
Merged
Conversation
The test exercised the legacy LSPS2 htlc_accepted hook in gl-plugin (lsp.rs) which was removed in 2cff324. With the hook gone, the test times out waiting for log lines that are no longer emitted. The underlying functionality is now handled natively by CLN's --experimental-lsps-client daemon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
test_lsp_jit_feefromlibs/gl-testing/tests/test_node.py.The test exercised the legacy LSPS2
htlc_acceptedhook ingl-plugin/src/lsp.rs, which was removed in 2cff324 (gl-plugin: Remove legacy LSPS2 htlc_accepted hook). With the hook gone, the test times out waiting for log lines (Serialized payload: .*fb0142) that are no longer emitted, causing CI failures on every branch based on currentmain.The underlying JIT channel functionality is now handled natively by CLN's
--experimental-lsps-clientdaemon.Motivation
This unblocks PR #716 and any other branch rebased on
mainafter 2cff324.Test plan