gl-plugin: Use call_typed for regular invoice creation#660
Open
gl-plugin: Use call_typed for regular invoice creation#660
Conversation
Before creating an LSPS2 invoice that requires JIT channel negotiation, check if the node already has sufficient incoming capacity to receive the payment directly. When the receivable capacity (with a 5% buffer for fees) exceeds the invoice amount, create a regular invoice instead of negotiating with the LSP. This avoids unnecessary LSP fees and channel opening costs when the node can already receive the payment. The capacity check: - Sums receivable_msat across all CHANNELD_NORMAL channels with connected peers - Applies a 5% buffer to account for routing fees - Falls back to JIT negotiation if capacity is insufficient or for 'any amount' invoices
Replace call_raw with call_typed when creating a regular invoice in the LSP invoice handler. This provides better type safety by using the generated cln_rpc::model::requests::InvoiceRequest and cln_rpc::model::responses::InvoiceResponse types. Benefits: - Compile-time type checking for request/response fields - No manual hex decoding needed for payment_hash/payment_secret - Access to created_index field from the response - Cleaner code without custom request/response structs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace call_raw with call_typed when creating a regular invoice in the LSP invoice handler. This provides better type safety by using the generated cln_rpc::model::requests::InvoiceRequest and cln_rpc::model::responses::InvoiceResponse types.
Benefits:
Depends on #658