feat(node): Add lsps2-invoice support to the plugin
#632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
changed the title
lsps2-invoice support to the plugin
cdecker
force-pushed
the
202510-lsps-invoice
branch
5 times, most recently
from
c99c0e1 to
401ff9a
Compare
Collaborator
Author
|
Rebased on top of #631 now that it's merged. |
cdecker
force-pushed
the
202510-lsps-invoice
branch
from
401ff9a to
0f2dc89
Compare
`invoice` for now is the one we will expose.
This takes care of incoming grpc requests, the conversion to JSON-RPC, then the actual call, as well as the conversion back from JSON-RPC result to grpc result.
We need something to test against, the dummy plugin just returns a fixed result, so the `cln-lsps-servive` plugin has something to work against.
The new CLN versions start the `cln-grpc` plugin by default, causing them to collide on the port, if not disabled.
cdecker
force-pushed
the
202510-lsps-invoice
branch
from
0f2dc89 to
7935b36
Compare
It's not being used by anyone, so why keep it. We're building a longer term LSPS2 implementation.
We were running inside the repo, which meant that the `.venv` directory was owned by the docker daemon's user (root). By specifying a separate `.venv` directory we ensure we don't accidentally leave root-owned directories in the repo.
The hope is to signal in a more clear manner that this is an invoice that is negotiated with a peer LSP.
cdecker
force-pushed
the
202510-lsps-invoice
branch
from
7935b36 to
46aa6dc
Compare
cdecker
force-pushed
the
202510-lsps-invoice
branch
from
89f47a3 to
65cb0bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds rudimentary support for the LSPS2 protocol, based on @nepet's CLN ElementsProject/lightning#8569 PR adding these features.
To make this work we had to do a bit of yak shaving:
mainversion, which uses a snapshot ofmasterfrom CLN. This version is used as a floating target for the network to use, when testing.renepay. We will use this in future to ensure even old versions get the upside of updates on the development branch.Notice that the test I added so far only tests the lsps-invoice call, not the actual execution. @nepet I think this is likely easiest for you to add and test.