gl-client-py: make retry_for optional #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retry_for argument in pay is optional in core-lightning let's keep it that way also during tests. We were trying to intercept pay requests and redirect them to xpay and renepay but with retry_for=0 renepay would inmediately fail. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retry_for argument in pay is optional in core-lightning let's keep it that way also during tests.
We were trying to intercept pay requests and redirect them to xpay and renepay but with retry_for=0 renepay would inmediately fail during testing sessions. We were not expecting that the value of retry_for was being set to 0 instead
of being forwarded as an optional argument.