Improve error handling #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
ACK f4acccd |
We wan't to be able to use the error framework across diferent greenlight crates. The util crate is a good place to store some common functionalities. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
We add a trait that helps to implement conversions between cln_rpc errors and the error codes provided by a module. This also involved some cleanups, a convenience macro and some remaning Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
We need to import it in the internal repo Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
cdecker
force-pushed
the
2524-538-improve-trampoline-errors
branch
from
f4acccd to
acf3009
Compare
cdecker
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the direct implementation of RpcErrors and replaces it with a conversion trait for modularity. This PR also cleans up some boilerplate and naming conventions and adds a convenience macro to allow for easy error creation.