Upgrade cln_grpc and cln_rpc
#590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nepet
force-pushed
the
2514-upgrade-cln-rpc-grpc
branch
from
60d617d to
f513baa
Compare
Upgrade cln crates and adapt changes to the messages. Changes AutoCleanInvoices to AutoCleanOnce Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
We need to upgrade those to match with the rest of the project. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
Upgrade to the current version and, adjust the wrapper and other messages to the changes. Need to fill out the streams after we made NotificationStream - respectively the server module public. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
nepet
force-pushed
the
2514-upgrade-cln-rpc-grpc
branch
from
f513baa to
49d71b8
Compare
cdecker
approved these changes
Apr 11, 2025
| .ok_or(Error::Channel("No channel with scid"))? | ||
| .status | ||
| .ok_or(Error::Channel("No amount found"))?) | ||
| return Err(Error::Service(format!( |
Collaborator
There was a problem hiding this comment.
Ok, this means we will deprecate any pre-v23.05 node in the prod system before rollout. That is intended I assume?
Collaborator
There was a problem hiding this comment.
For reference, that is currently about <1% of nodes, and <0.01% of active nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to keep up with changes in
tonicandprostas well as changes in the upstream cln repo we need to upgrade those crates once in a while.The newly added streams from
cln_grpcare left to be implemented in the future as we need to access a module that is currently private.