signer: Add CLN v24.11 to supported versions #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
202504-signer-for-v2411
branch
from
e246e5d to
be33f03
Compare
cdecker
force-pushed
the
202504-signer-for-v2411
branch
2 times, most recently
from
6c723c8 to
d15bd09
Compare
cdecker
force-pushed
the
202504-signer-for-v2411
branch
from
35d268c to
8520a48
Compare
We first had to bounce the node version to disable the annoying `hsmd_preinit`.
cdecker
force-pushed
the
202504-signer-for-v2411
branch
from
8520a48 to
fc8f3dc
Compare
Collaborator
Author
|
The new version has been tested extensively both internally and externally, so we're merging this as is 👍 Thanks everyone for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for CLN v24.11. It'll trigger an upgrade on the
node as soon as it connects the first time, and will act as its signer
from thereon.
We're keeping it a draft, while we verify the core functionality, and
will merge as soon as it is deemed stable. Feel free to use this
signer version, however be aware that there is currently no way to
downgrade once upgraded, so use test nodes.