tramp: account for retried payments #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
December 19, 2024 17:27
Head branch was pushed to by a user without write access
JssDWt
force-pushed
the
jssdwt-fix-group-id
branch
3 times, most recently
from
5fb5b22 to
a0bdae7
Compare
Ensure trampoline payments follow the following behavior: - When a payment with the same payment hash had already completed, return a completed response. - When a payment with the same payment hash is pending, return an error (ideally it should wait for payment parts to return) - When a payment for the same payment hash is retried, bump the group id.
cdecker
force-pushed
the
jssdwt-fix-group-id
branch
from
a0bdae7 to
d97d12a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure trampoline payments follow the following behavior:
Fixes
Error code 201: There already is a payment with payment_hash=xxxxx, groupid=1, partid=0. Either change the partid, or wait for the payment to complete and start a new group.Also fixes potential accidental subsequent pays to the same payment hash.