ts: Add Dockerfile and make targets
#551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
202448-testserver-dx
branch
from
c05addc to
00ce181
Compare
cdecker
force-pushed
the
202448-testserver-dx
branch
from
00ce181 to
c58a396
Compare
We want to ensure that we can run both inside and outside the docker container, thus we better make sure that the repo inside and outside of the docker container use the same paths and permissions.
We were mapping the ports and the source into the docker image, but we were not mapping the certs out into the host. Without this the host could not connect as it had no valid certificates to check against.
When mounting in the repository, along with its target directory, we might have some issue if the host arch does not match the guest arch. We'd either use the host binary on the guest arch, or we end up compiling the guest into the host target dir, meaning the host won't work anymore. By moving the target dir into a separate directory we then don't touch the hosts' binaries.
cdecker
force-pushed
the
202448-testserver-dx
branch
from
c58a396 to
88b9239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some followup fixes, and tweaks. It should be workable now.