feat(openapi-generator): support Identifier type in route expressions #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcrosson-bitgo
force-pushed
the
DX-1604-feat-openapi-generator-support-identifier-type-in-route-expressions
branch
from
1ea8bea to
61b5acf
Compare
ericcrosson-bitgo
force-pushed
the
DX-1604-feat-openapi-generator-support-identifier-type-in-route-expressions
branch
from
61b5acf to
a252f30
Compare
Add support for passing variables directly to apiSpec() without
requiring object literal syntax with spread operator.
Previously, this would fail:
```typescript
export const MyApiSpec = apiSpec(myApiSpecProps);
```
And required this workaround:
```typescript
export const MyApiSpec = apiSpec({
...myApiSpecProps
});
```
This change resolves identifiers when passed directly to apiSpec(),
handling both nested and imported identifiers.
Closes Ticket: DX-1604
ericcrosson-bitgo
force-pushed
the
DX-1604-feat-openapi-generator-support-identifier-type-in-route-expressions
branch
from
a252f30 to
c6fdcbe
Compare
|
🎉 This PR is included in version @api-ts/openapi-generator@5.9.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/typed-express-router@2.0.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/express-wrapper@2.0.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for passing variables directly to apiSpec() without
requiring object literal syntax with spread operator.
Previously, this would fail:
And required this workaround:
This change resolves identifiers when passed directly to apiSpec(),
handling both nested and imported identifiers.
Closes Ticket: DX-1604