feat: add ETH support for multisign in external mode#207
Closed
pranishnepal wants to merge 1 commit into
Closed
Conversation
This commit adds support for signing multisig transactions for ETH in external mode. It includes validation to ensure that the transaction prebuild contains the necessary fields for ETH transactions, such as recipients and nextContractSequenceId. The tests have been updated to reflect these changes and to ensure that the new functionality works as expected - tested e2e. Re Recovery Flow: it requires a few methods that are not exposed by COINS team, so that will be a follow-up work. Ticket: WAL-1486
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for signing multisig transactions for ETH in external mode. It includes validation to ensure that the transaction prebuild contains the necessary fields for ETH transactions, such as recipients and nextContractSequenceId.
The tests have been updated to reflect these changes and to ensure that the new functionality works as expected - tested e2e.
Re Recovery Flow: it requires a few methods that are not yet exposed -- COINS team are working on that. So that will be a follow-up work.
Ticket: WAL-1486