feat(wasm-utxo): implement BCH fork ID support and extend wallet capabilities #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark FixedScript Wallet Transaction Support for Bitcoin and Litecoin as complete in the feature status table. Issue: BTC-2656 Co-authored-by: llm-git <llm-git@ttll.de>
Implement fork ID support for Bitcoin Cash-style networks to enable proper signing and verification. This includes: - Use fork ID-aware signing for BCH (0), BTG (79), XEC (0), and BSV (0) - Update miniscript dependency to use forkid-compatible version - Modify PSBT functions to use the appropriate sighash algorithm - Ensure replay protection inputs use correct sighash calculation - Add tests to verify sign→verify roundtrip works correctly Issue: BTC-2656 Co-authored-by: llm-git <llm-git@ttll.de>
Updates the feature status in README to reflect that Bitcoin Cash and Bitcoin Gold now have complete transaction support in the FixedScript wallet. Issue: BTC-2656 Co-authored-by: llm-git <llm-git@ttll.de>
Extract fixture network filtering into a utility function. This improves code organization and reduces duplication across test files. Now includes bitcoincash and bitcoingold in fixture networks. Issue: BTC-2656 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-2656.bch-forkid
branch
from
a57ff37 to
9cfedc8
Compare
davidkaplanbitgo
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Bitcoin Cash-style fork ID support for multiple networks (BCH,
XEC, BSV, BTG) and extends the FixedScript wallet transaction capabilities
to include Bitcoin Cash and Bitcoin Gold.
Key changes:
status matrix
Issue: BTC-2656