feat: redesign TransactionIntent as high-level business intents#200
Open
feat: redesign TransactionIntent as high-level business intents#200
Conversation
Replace low-level call intents (Transfer, Bond, Unbond, AddProxy, etc.) with business-level intents (Payment, Consolidate, Stake, Unstake, Claim, FillNonce). The crate now handles intent-to-call composition internally, including automatic batching for multi-call operations. Composition logic: - Payment → transfer or transferKeepAlive - Consolidate → transferAll - Stake with proxyAddress → batchAll(bond, addProxy) - Stake without proxyAddress → bondExtra (top-up) - Unstake with stopStaking → batchAll(removeProxy, chill, unbond) - Unstake without stopStaking → unbond - Claim → withdrawUnbonded - FillNonce → zero-value transferKeepAlive to self Old call-level types are now internal CallIntent (not public). Includes bondExtra encoding (previously missing). 47 tests pass (18 new composition + deserialization tests). Ticket: BTC-3120
ea2d340 to
5a24cee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign
TransactionIntentfrom low-level call intents (Transfer, Bond,Unbond, AddProxy, etc.) to high-level business intents (Payment, Consolidate,
Stake, Unstake, Claim, FillNonce). The crate now handles intent-to-call
composition internally, including automatic batching for multi-call operations.
Old call-level types become internal
CallIntent(not public). This matchesthe pattern established by
wasm-solana, wherebuildFromIntentacceptsbusiness-level intents and handles instruction composition in Rust.
Composition logic
Also adds the previously missing
bondExtracall encoding.47 tests pass (18 new composition + deserialization tests).
Ticket: BTC-3120