feat: enhance coin name retrieval by adding dynamic lookup for chain IDs #7807
+172
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-damkondwar
force-pushed
the
WIN-8082
branch
2 times, most recently
from
20a798b to
cc362d0
Compare
mukeshsp
reviewed
Dec 29, 2025
Contributor
mukeshsp
left a comment
mukeshsp
left a comment
There was a problem hiding this comment.
Could you please add test case to verify the changes ?
shubham-damkondwar
force-pushed
the
WIN-8082
branch
from
cc362d0 to
3861dc8
Compare
Contributor
Author
Added the tests |
mukeshsp
reviewed
Dec 29, 2025
Contributor
mukeshsp
left a comment
mukeshsp
left a comment
There was a problem hiding this comment.
Can you remove the conflict and re-request ?
shubham-damkondwar
force-pushed
the
WIN-8082
branch
from
3861dc8 to
528d736
Compare
shubham-damkondwar
force-pushed
the
WIN-8082
branch
from
528d736 to
b17e35a
Compare
mukeshsp
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-8082