feat: PSBTify cross-chain recovery transactions #7766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace legacy transaction builder with PSBT for cross-chain recovery, aligning with the pattern used in backupKeyRecovery.ts. Changes: - Use UtxoPsbt for both signed and unsigned cross-chain recovery - Add signAndVerifyPsbt for signing with user key - Make txInfo optional in response interfaces (PSBT is self-contained) - Remove unused legacy functions (getTxInfo, old createSweepTransaction) Test updates: - Fix nested it() blocks that were never executing - Add 142 fixture files for cross-chain recovery combinations Ticket: BTC-2890 TICKET: BTC-2890
OttoAllmendinger
approved these changes
Dec 18, 2025
| version: 1 | 2; | ||
| txHex: string; | ||
| txInfo: TransactionInfo<TNumber>; | ||
| txInfo?: TransactionInfo<TNumber>; |
Contributor
There was a problem hiding this comment.
I think we might to fully get rid of these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace legacy transaction builder with PSBT for cross-chain recovery, aligning with the pattern used in backupKeyRecovery.ts.
Changes:
Test updates:
Ticket: BTC-2890
TICKET: BTC-2890