Skip to content

fix(sdk-coin-iota): update merge coin params #7711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yash-bitgo merged 1 commit into from
Dec 9, 2025
Merged

fix(sdk-coin-iota): update merge coin params #7711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions modules/sdk-coin-iota/src/lib/transferTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,12 @@ export class TransferTransaction extends Transaction {
const firstObject = this._iotaTransaction.object(IotaInputs.ObjectRef(this.paymentObjects[0]));

// Single object doesn't need consolidation
if (this.paymentObjects.length === 1) {
return firstObject;
if (this.paymentObjects.length > 1) {
// Merge extra objects into the first one
this.mergeObjectsInBatches(firstObject, this.paymentObjects.slice(1), MAX_INPUT_OBJECTS);
}

// Merge remaining objects into the first one
return this.mergeObjectsInBatches(firstObject, this.paymentObjects.slice(1), MAX_INPUT_OBJECTS);
return firstObject;
}

/**
Expand All @@ -253,13 +253,12 @@ export class TransferTransaction extends Transaction {

const gasObject = this._iotaTransaction.gas;

// If within the limit, no consolidation needed
if (this.gasPaymentObjects.length <= MAX_GAS_PAYMENT_OBJECTS) {
return gasObject;
if (this.gasPaymentObjects.length > MAX_GAS_PAYMENT_OBJECTS) {
// Merge excess gas objects to stay within limits
this.mergeObjectsInBatches(gasObject, this.gasPaymentObjects, MAX_INPUT_OBJECTS);
}

// Merge excess gas objects to stay within limits
return this.mergeObjectsInBatches(gasObject, this.gasPaymentObjects, MAX_INPUT_OBJECTS);
return gasObject;
}

/**
Expand All @@ -275,17 +274,13 @@ export class TransferTransaction extends Transaction {
targetCoin: TransactionObjectArgument,
objectsToMerge: TransactionObjectInput[],
batchSize: number
): TransactionObjectArgument {
let consolidatedCoin = targetCoin;

): void {
for (let startIndex = 0; startIndex < objectsToMerge.length; startIndex += batchSize) {
const batch = objectsToMerge.slice(startIndex, startIndex + batchSize);
const batchAsTransactionObjects = batch.map((obj) => this._iotaTransaction.object(IotaInputs.ObjectRef(obj)));

[consolidatedCoin] = this._iotaTransaction.mergeCoins(consolidatedCoin, batchAsTransactionObjects);
this._iotaTransaction.mergeCoins(targetCoin, batchAsTransactionObjects);
}

return consolidatedCoin;
}

/**
Expand Down