fix(express): support legacy EIP1559 transaction in type valid… #7701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baltiyal
force-pushed
the
WIN-8042-avaxc-usdc-signer-issue
branch
2 times, most recently
from
7aaf1d2 to
aa79ca2
Compare
baltiyal
changed the title
baltiyal
force-pushed
the
WIN-8042-avaxc-usdc-signer-issue
branch
from
aa79ca2 to
6c5e13f
Compare
lokesh-bitgo
reviewed
Dec 5, 2025
lokesh-bitgo
reviewed
Dec 5, 2025
lokesh-bitgo
approved these changes
Dec 5, 2025
Contributor
lokesh-bitgo
left a comment
lokesh-bitgo
left a comment
There was a problem hiding this comment.
Had a discussion with @baltiyal. The type codec for EIP1559 defined in the current code is correct and aligned with the AVAXC type codec.
However, the AVAXC token behavior is slightly different — after the transaction is built at BGMS, it sends a new field isEip1559 inside the EIP1559 type and does not pass the other two fields. This is why it was not working for AVAXC tokens.
Since we have introduced type codecs for all Express endpoints, any coin specific request/response changes made on the BGMS side need to be reflected on the Express side as well to avoid impacts to clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: WIN-8042