fix(abstract-eth): add consolidate type and validation for TSS wallets #7554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpkjnr
force-pushed
the
fix-eth-tss-consolidation-validation
branch
from
ab1599d to
ba1e828
Compare
dpkjnr
force-pushed
the
fix-eth-tss-consolidation-validation
branch
3 times, most recently
from
fd366e4 to
ab25b8f
Compare
nvjsr
reviewed
Dec 3, 2025
There was a problem hiding this comment.
Pull request overview
This PR adds support for TSS wallet consolidation transaction validation for Ethereum-like coins. It extends the transaction verification logic to properly identify and handle consolidation transactions in multiple ways (via consolidateId, type: 'consolidate', etc.) and implements address verification to ensure consolidation transactions send funds to the wallet's base address.
Key changes:
- Added
'consolidate'to the list of valid transaction types that don't require recipients - Added
txPrebuild?.consolidateIdas an additional check for identifying consolidation transactions - Implemented
consolidationToBaseAddressverification logic to validate the transaction recipient matches the wallet's base address
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/abstract-eth/src/abstractEthLikeNewCoins.ts | Added validation logic to accept consolidation transactions and verify they send to the correct base address |
| modules/sdk-coin-eth/test/unit/eth.ts | Added test cases to verify TSS consolidation transactions are accepted with various consolidation indicators |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dpkjnr
force-pushed
the
fix-eth-tss-consolidation-validation
branch
from
ab25b8f to
45f4f53
Compare
nvjsr
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: COIN-6431