feat(utxo-lib): enhance PSBT fixtures and utilities #7467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add clonePsbtWithoutNonWitnessUtxo function to tests and run test fixtures in both normal and 'lite' mode (without nonWitnessUtxo). Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
When a transaction is fully signed, include the extracted transaction in the fixture data for testing and reference purposes. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Add `psbtInputsFinalized` property to PSBT fixtures that shows the state of inputs after finalization but before extraction to a raw transaction. This will help with debugging and testing PSBT finalization. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Add standalone utility functions to handle proprietary keyvalues in PSBT, making them usable even without access to the PSBT methods. These helpers support the getting, adding, updating, and deleting of proprietary keyvalues from unknown keyvalues arrays. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Add fields for musig2Participants, musig2Nonces, and musig2PartialSigs to PSBT fixtures that makes the data structure more accessible and easier to understand compared to the raw key-value pairs. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Include finalized PSBT in base64 format in test fixtures when available to help with debugging and verification. Issue: BTC-2742 Co-authored-by: llm-git <llm-git@ttll.de>
Add option to disable derivation info on outputs, allowing creation of external wallet outputs in PSBTs. Also add support for creating OP_RETURN outputs in test utilities and expose a function to create wallet keys from custom seeds. Issue: BTC-2742 Co-authored-by: llm-git <llm-git@ttll.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several enhancements to PSBT (Partially Signed Bitcoin
Transaction) functionality in utxo-lib:
These improvements enhance the test infrastructure and provide better
support for working with various PSBT scenarios.
Issue: BTC-2652, BTC-2742