fix: validate 32-byte message requirement when shouldHash=false #7426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orentysor
changed the title
orentysor
changed the title
…en shouldHash=false When shouldHash=false, the message must be exactly 32 bytes (a hash). Messages longer than 32 bytes caused calculation errors (messages larger than the curve order when converted to bigint) or verification failures because secp256k1.recoverPublicKey() expects exactly 32 bytes. Adds validation in sign() and verify() methods to enforce this requirement and adds tests to verify the fix. Refs: HSM-129 TICKET: HSM-129
orentysor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shouldHash=false, the message must be exactly 32 bytes (a hash). Messages longer than 32 bytes caused calculation errors (messages larger than the curve order when converted to bigint) or verification failures because secp256k1.recoverPublicKey() expects exactly 32 bytes.
Adds validation in sign() and verify() methods to enforce this requirement and adds tests to verify the fix.
Refs: HSM-129