Skip to content

Conversation

@mohd-kashif
Copy link
Contributor

TICKET: WIN-7747

@mohd-kashif mohd-kashif self-assigned this Nov 1, 2025
@mohd-kashif mohd-kashif changed the title WIN-7747 WIN-7747 | fixed Utils and KeyPair and added test cases Nov 1, 2025
@mohd-kashif mohd-kashif changed the title WIN-7747 | fixed Utils and KeyPair and added test cases WIN-7747 | fixed Utils and KeyPair and added test cases for FLRP Nov 1, 2025
@mohd-kashif mohd-kashif force-pushed the WIN-7747 branch 2 times, most recently from 9679858 to 0a36ea9 Compare November 1, 2025 16:50
@mohd-kashif mohd-kashif requested a review from Copilot November 1, 2025 16:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements comprehensive support for Flare P-Chain (FLRP) functionality, including address validation, transaction/block ID validation, signature operations, and key pair management. The changes migrate from placeholder implementations to production-ready code with proper bech32 and CB58 encoding support.

  • Adds proper bech32 and CB58 encoding/decoding utilities for Flare addresses and IDs
  • Implements validation for addresses, transaction IDs, and block IDs
  • Updates test suite with real test data and comprehensive test coverage
  • Adds new ImportToC transaction type for cross-chain transfers

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
modules/sdk-core/src/account-lib/baseCoin/enum.ts Adds ImportToC transaction type and updates comment to include Flare
modules/sdk-coin-flrp/test/unit/lib/utils.ts Replaces placeholder tests with comprehensive validation tests using real addresses and IDs
modules/sdk-coin-flrp/test/unit/lib/keyPair.ts New test file with comprehensive KeyPair functionality tests
modules/sdk-coin-flrp/test/unit/lib/importInPTxBuilder.ts Skips failing test pending sourceChain method fix
modules/sdk-coin-flrp/test/unit/lib/importInCTxBuilder.ts Skips failing test pending sourceChain method fix
modules/sdk-coin-flrp/test/resources/account.ts New test data file with account fixtures for testing
modules/sdk-coin-flrp/src/lib/utils.ts Implements CB58 encoding/decoding, bech32 address parsing, and ID validation
modules/sdk-coin-flrp/src/lib/keyPair.ts Adds PrivateKey- format support and updates network identifiers
modules/sdk-coin-flrp/package.json Adds bech32 and bs58 dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mohd-kashif mohd-kashif marked this pull request as ready for review November 3, 2025 07:30
@mohd-kashif mohd-kashif requested review from a team as code owners November 3, 2025 07:30
Copy link
Contributor

@nvjsr nvjsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mohd-kashif mohd-kashif merged commit 9430870 into master Nov 3, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants