feat: support original url for hmac calculation #7393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: ANT-1086
Description
In bitgo-ui, auth-service, and WP, the original url from
x-original-uriis used for hmac calculation with no url parsing. The url parsing typically produces the same url except in some edge cases where there is a trailing?. This has resulted in hmac mismatch when switching the hmac calculation to usesdk-hmacin these services.To ensure existing client flows don't break, this PR adds a
useOriginalPathparameter tocalculateHMACSubjectwhich will use the url passed tocalculateHMACSubjectwith no parsing if it is true. The default value of this parameter is false, so as not to break existing sdk flows. In the above services, I will set it to true.Issue Number
ANT-1086
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Checklist: