feat(abstract-utxo): move utxo tests from bitgo/ to abstract-utxo/
#7331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoAllmendinger
force-pushed
the
BTC-2652.move-abstract-utxo-tests
branch
from
4e107db to
89dec78
Compare
OttoAllmendinger
changed the title
bitgo/ to abstract-utxo/
zahin-mohammad
previously approved these changes
Oct 24, 2025
ppongbitgo
previously approved these changes
Oct 25, 2025
Return specific coin types from createInstance rather than the generic BaseCoin type to improve type safety and eliminate the need for casting. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
This makes the development cycle more pleasant because we don't have to go to some other module to test the `abstract-utxo` implementation. Replaced imports of `BitGo` which pull in the full cursed deptree with imports of the more modern TestBitGo which has a much lighter deptree. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Use internal coin implementations from abstract-utxo instead of the sdk modules for test files. Replace fs-extra with node's fs/promises. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Remove @bitgo/blockapis and fs-extra dependencies that are declared but not used in the code. This fixes the code-quality (dependencies) CI check failure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Issue: BTC-2652
OttoAllmendinger
dismissed stale reviews from ppongbitgo and zahin-mohammad
via
0a59a50
OttoAllmendinger
force-pushed
the
BTC-2652.move-abstract-utxo-tests
branch
from
e4d81bd to
0a59a50
Compare
Contributor
Author
|
resolved merge conflicts |
zahin-mohammad
approved these changes
Oct 27, 2025
ppongbitgo
approved these changes
Oct 27, 2025
davidkaplanbitgo
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two main improvements to the abstract-utxo module:
Return specific coin types from createInstance rather than the generic
BaseCoin type to improve type safety and eliminate the need for casting.
Move UTXO test files to the abstract-utxo module for a more pleasant
development cycle, allowing direct testing of the implementation without
navigating to other modules. This change also replaces imports of the
heavy
BitGodependency with the lighterTestBitGo.Issue: BTC-2652