Skip to content

fix: Payment gives NO_ROUTE error on passing the amountMsat #7302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andyyan162 wants to merge 1 commit into from
Closed

fix: Payment gives NO_ROUTE error on passing the amountMsat #7302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions modules/abstract-lightning/src/wallet/lightning.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,22 @@ export class LightningWallet implements ILightningWallet {
},
};

// Convert BigInt values to strings for proper JSON serialization to backend
// This fixes NO_ROUTE errors caused by BigInt serialization issues
const encodedPaymentIntent = t.type({ intent: LightningPaymentIntent }).encode(paymentIntent);
const intentAny = encodedPaymentIntent.intent as any;
if (intentAny.signedRequest) {
if (intentAny.signedRequest.amountMsat !== undefined) {
intentAny.signedRequest.amountMsat = intentAny.signedRequest.amountMsat.toString();
}
if (intentAny.signedRequest.feeLimitMsat !== undefined) {
intentAny.signedRequest.feeLimitMsat = intentAny.signedRequest.feeLimitMsat.toString();
}
}

const transactionRequestCreate = (await this.wallet.bitgo
.post(this.wallet.bitgo.url('/wallet/' + this.wallet.id() + '/txrequests', 2))
.send(t.type({ intent: LightningPaymentIntent }).encode(paymentIntent))
.send(encodedPaymentIntent)
.result()) as TxRequest;

if (transactionRequestCreate.state === 'pendingApproval') {
Expand Down Expand Up @@ -338,7 +351,6 @@ export class LightningWallet implements ILightningWallet {
onchainRequest: {
recipients: params.recipients,
satsPerVbyte: params.satsPerVbyte,
numBlocks: params.numBlocks,
},
intentType: 'payment',
},
Expand Down
Loading