Skip to content

Conversation

@sasikumar-bitgo
Copy link
Contributor

@sasikumar-bitgo sasikumar-bitgo commented Oct 20, 2025

Description

Enhances calculateHMAC in the sdk-hmac module to support all key and message types accepted by crypto.createHmac. Adds delete to the list of supported HTTP methods and normalizes del to delete for improved backward compatibility with legacy request methods.

Issue Number

TICKET: ANT-1025

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code compiles correctly for both Node and Browser environments
  • I have commented my code, particularly in hard-to-understand areas
  • My commits follow Conventional Commits and I have properly described any BREAKING CHANGES
  • The ticket or github issue was included in the commit message as a reference
  • I have made corresponding changes to the documentation and on any new/updated functions and/or methods - jsdoc
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sasikumar-bitgo sasikumar-bitgo force-pushed the feat/ANT-1025/hmac-enhancements branch 2 times, most recently from d955751 to 3068f37 Compare October 20, 2025 09:40
@sasikumar-bitgo sasikumar-bitgo marked this pull request as ready for review October 20, 2025 11:36
@sasikumar-bitgo sasikumar-bitgo requested review from a team as code owners October 20, 2025 11:36
@bdesoky
Copy link
Contributor

bdesoky commented Oct 20, 2025

Merging on @sasikumar-bitgo's request

@bdesoky bdesoky merged commit 062be3d into master Oct 20, 2025
33 of 36 checks passed
@sasikumar-bitgo sasikumar-bitgo deleted the feat/ANT-1025/hmac-enhancements branch October 21, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants