feat(sdk-core): generate Go account wallet #7268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@claude review as grug |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for generating Go Account wallets through the SDK's generateWallet endpoint, streamlining the CaaS Go Account creation process. Go Accounts use a single user keychain (1-of-1 signature) and are identified by the wallet type 'trading' within the 'ofc' coin family.
Key Changes:
- Added a dedicated
generateGoAccountWalletmethod to handle Go Account wallet creation with single keychain - Introduced
GoAccountWalletWithUserKeychaintype to represent the unique structure of Go Account wallets - Extended
Keychaininterface to includeethAddressfield for Ethereum address derived from xpub
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/sdk-core/src/bitgo/wallet/wallets.ts | Implements Go Account wallet generation logic and routing based on 'ofc' family + 'trading' type |
| modules/sdk-core/src/bitgo/wallet/iWallets.ts | Defines types and interfaces for Go Account wallet generation options and return type |
| modules/sdk-core/src/bitgo/keychain/iKeychains.ts | Adds optional ethAddress field to Keychain interface |
| modules/sdk-core/src/bitgo/baseCoin/iBaseCoin.ts | Extends wallet type enum to include 'trading' for Go Accounts |
| modules/bitgo/test/v2/unit/wallets.ts | Adds unit test coverage for Go Account wallet generation flow |
| examples/ts/create-go-account.ts | Provides example script demonstrating Go Account wallet creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sampras-saha
approved these changes
Oct 17, 2025
Contributor
sampras-saha
left a comment
sampras-saha
left a comment
There was a problem hiding this comment.
LGTM, with some comments
abrarrakin144
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: CAAS-491
GoAccountWalletWithUserKeychaintype since Go accounts operate with 1 key - the user keyethAddresssince that was missing from the types but various wallet types has an ethAddress derived from the xpub key in the keychain (checked it out with Go, lightning btc, and hot self-custody)