fix(utxo-lib): clarify musig2 implementation notes #7251
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation is not the final Musig2 spec but an earlier variant that aggregates x-only pubkeys. Added reference to specific implementation details and updated test comments. Issue: BTC-2651 Co-authored-by: llm-git <llm-git@ttll.de>
davidkaplanbitgo
approved these changes
Oct 15, 2025
parvbitgo067
approved these changes
Oct 16, 2025
Contributor
Author
|
actually it's more complicated than what I wrote |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is not the final Musig2 spec but an earlier
variant that aggregates x-only pubkeys. Added reference to specific
implementation details and updated test comments.
Issue: BTC-2651