Skip to content

Conversation

@ravibitgo
Copy link
Contributor

@ravibitgo ravibitgo commented Oct 14, 2025

Ticket: COIN-5918

@ravibitgo ravibitgo requested review from a team as code owners October 14, 2025 10:45
Copy link
Contributor

@at31416 at31416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@borkds borkds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@gianchandania gianchandania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have you added a js file and not a ts file?

@ravibitgo
Copy link
Contributor Author

ravibitgo commented Oct 14, 2025

why have you added a js file and not a ts file?

This is actually the helper util file from the canton wallet SDK, we've taken a call that we won't be using the SDK because of long dependency tail.
COIN-6016 - I have added this ticket to refactor this to ts. Because of time constraints, right now going with js

@ravibitgo ravibitgo merged commit 909d39d into master Oct 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants