Skip to content

Conversation

@kaustubhbitgo
Copy link
Contributor

Ticket: WP-6312

@kaustubhbitgo kaustubhbitgo force-pushed the WP-6312-express-add-supertest-ci-workflow-to-mock-and-verify-express-routes branch from 39b2040 to 54a1e9b Compare October 14, 2025 06:33
@kaustubhbitgo kaustubhbitgo changed the title feat(express): setup integration test feat(express): add supertest for createAddress Oct 14, 2025
@kaustubhbitgo kaustubhbitgo marked this pull request as ready for review October 14, 2025 06:45
@kaustubhbitgo kaustubhbitgo requested a review from a team as a code owner October 14, 2025 06:45
Copy link
Contributor

@lokesh-bitgo lokesh-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already have an integration directory within test, should we move these tests there for consistency?

@kaustubhbitgo kaustubhbitgo force-pushed the WP-6312-express-add-supertest-ci-workflow-to-mock-and-verify-express-routes branch from 54a1e9b to cae56ab Compare October 14, 2025 07:44
Copy link
Contributor

@kisslove-dewangan kisslove-dewangan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaustubhbitgo
Copy link
Contributor Author

Since we already have an integration directory within test, should we move these tests there for consistency?

Those are legacy integration test or we should call them e2e tests, they are not run when CI tests are run. Basically they call actual WP APIs instead mocking.

@kaustubhbitgo kaustubhbitgo merged commit 3bff6cc into master Oct 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants