Refactor test setup/teardown to reuse connection across tests#155
Open
justing-bq wants to merge 2 commits intoapache-odbcfrom
Open
Refactor test setup/teardown to reuse connection across tests#155justing-bq wants to merge 2 commits intoapache-odbcfrom
justing-bq wants to merge 2 commits intoapache-odbcfrom
Conversation
justing-bq
force-pushed
the
mockTestSetupTeardown
branch
2 times, most recently
from
183fa4d to
2922812
Compare
justing-bq
changed the title
justing-bq
force-pushed
the
apache-odbc
branch
from
2336a2d to
fcb22f1
Compare
justing-bq
force-pushed
the
mockTestSetupTeardown
branch
from
2922812 to
1f59664
Compare
justing-bq
changed the title
justing-bq
force-pushed
the
mockTestSetupTeardown
branch
from
1f59664 to
e740c26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Possible workaround to apache#49207 because it involves fewer setups/teardowns.
What changes are included in this PR?
Our mock test Setup/Teardown logic now happens once at the environment level.
Our test connect/disconnect now happens once per test fixture instead of once per test.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.