-
Notifications
You must be signed in to change notification settings - Fork 23
[Bdt] Switch to dcargs #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Greg Balke <gbalke@berkeley.edu> Topic: bdt_uses_dcargs Reviewers: brent
|
Reviews in this chain: |
bd_tools/src/bd_tools/boards.py
Outdated
| """ | ||
|
|
||
|
|
||
| actuation: dcargs.conf.Positional[str] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably a literal could be used here?
from typing import Literal
actuation: Literal["current", "phase"], etc
|
|
||
|
|
||
| actuation: dcargs.conf.Positional[str] | ||
| values: dcargs.conf.Positional[List[Tuple[float, float, float]]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general, variable-length positional arguments are scary because it means you can't have add more positional args afterward
|
|
||
| board_ids = make_type(make_list(ast.literal_eval(args.board_ids)), int) | ||
| board_ids = make_type( | ||
| make_list(ast.literal_eval(args.motor.board_ids)), int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still needed? since board_ids is annotated as List[int] now
|
Discussed offline... I think the current behavior where betz drive tools creates a connection per tool execution is a pretty poor design for doing continuous testing. I believe |
83f4182 to
0b7072f
Compare
Signed-off-by: Greg Balke gbalke@berkeley.edu
Topic: bdt_uses_dcargs
Reviewers: brent