Allow localhost origins #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmileham
approved these changes
Apr 12, 2025
Member
jmileham
left a comment
jmileham
left a comment
There was a problem hiding this comment.
Great find! Domain Lgtm platform Lgtm. I don't recall the release mechanics for this but maybe release notes and version bump if that's a thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use the Chrome extension on localhost. As I changed splits, they would fail to save and the page would reload. I managed to intercept the error by setting a breakpoint on the beforeunload event.
After doing a little digging, it seems like our CORS allowlist isn't working correctly because the
originis a URI (e.g. http://localhost:3000), not a hostname.In order to avoid any breaking changes, I didn't change the
TESTTRACK_ALLOWED_ORIGINSlogic, but it seems like what we actually want is for those to apply to the hostname, rather than the URI.