Skip to content

Fix test flakes #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smudge merged 2 commits into from
Feb 6, 2025
Merged

Fix test flakes #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1701cd
Deprecated in favor of go modules, which we already support
smudge Feb 3, 2025
a3cef03
Fix test flakes: the 'control' and 'treatment' variants are currently…
smudge Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Brewfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
brew 'dep'
brew 'go'
brew 'hub'
38 changes: 30 additions & 8 deletions fakeserver/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,22 @@ func TestVisitorConfig(t *testing.T) {
err := json.Unmarshal(w.Body.Bytes(), &visitorConfig)
require.Nil(t, err)

split := visitorConfig.Splits[0]
var control, treatment v4Variant
for _, v := range split.Variants {
if v.Name == "control" {
control = v
}
if v.Name == "treatment" {
treatment = v
}
}

require.Equal(t, 1, visitorConfig.ExperienceSamplingWeight)
require.Equal(t, "test.test_experiment", visitorConfig.Splits[0].Name)
require.Equal(t, 60, visitorConfig.Splits[0].Variants[0].Weight)
require.Equal(t, 40, visitorConfig.Splits[0].Variants[1].Weight)
require.Equal(t, false, visitorConfig.Splits[0].FeatureGate)
require.Equal(t, "test.test_experiment", split.Name)
require.Equal(t, 60, control.Weight)
require.Equal(t, 40, treatment.Weight)
require.Equal(t, false, split.FeatureGate)
require.Equal(t, "00000000-0000-0000-0000-000000000000", visitorConfig.Visitor.ID)
require.Equal(t, "something_something_enabled", visitorConfig.Visitor.Assignments[0].SplitName)
require.Equal(t, "true", visitorConfig.Visitor.Assignments[0].Variant)
Expand All @@ -184,11 +195,22 @@ func TestAppIdentifier(t *testing.T) {
err := json.Unmarshal(w.Body.Bytes(), &visitorConfig)
require.Nil(t, err)

split := visitorConfig.Splits[0]
var control, treatment v4Variant
for _, v := range split.Variants {
if v.Name == "control" {
control = v
}
if v.Name == "treatment" {
treatment = v
}
}

require.Equal(t, 1, visitorConfig.ExperienceSamplingWeight)
require.Equal(t, "test.test_experiment", visitorConfig.Splits[0].Name)
require.Equal(t, 60, visitorConfig.Splits[0].Variants[0].Weight)
require.Equal(t, 40, visitorConfig.Splits[0].Variants[1].Weight)
require.Equal(t, false, visitorConfig.Splits[0].FeatureGate)
require.Equal(t, "test.test_experiment", split.Name)
require.Equal(t, 60, control.Weight)
require.Equal(t, 40, treatment.Weight)
require.Equal(t, false, split.FeatureGate)
require.Equal(t, "00000000-0000-0000-0000-000000000000", visitorConfig.Visitor.ID)
require.Equal(t, "something_something_enabled", visitorConfig.Visitor.Assignments[0].SplitName)
require.Equal(t, "true", visitorConfig.Visitor.Assignments[0].Variant)
Expand Down