Skip to content

[Snyk] Security upgrade github-pages from 214 to 216 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BertsLifee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade github-pages from 214 to 216 #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
source "https://rubygems.org"

gem 'github-pages', '>= 207'
gem 'github-pages', '>= 216'
Copy link

@gemini-code-assist gemini-code-assist bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version constraint >= 216 is very broad and could pull in future, potentially breaking, versions of github-pages when bundle update is run. This can lead to unexpected failures.

While the PR title mentions upgrading to version 216, bundle update has resolved the version to 232 in Gemfile.lock. To ensure predictable builds and align with the lock file, it's recommended to use a pessimistic version constraint around the version that is actually being installed.

Using ~> 232 will restrict updates to versions >= 232 and < 233. Since github-pages uses integer versioning, this effectively pins the dependency to version 232, preventing accidental upgrades to a new, potentially breaking, version.

gem 'github-pages', '~> 232'

gem 'html-proofer', '>= 3.13.0'
gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw]
Loading