Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 16, 2025

Sample modules are now excluded from deployment via -pl and -am Maven switches in the root pom's maven-release-plugin. Legacy plugin-level skip configurations in samples/pom.xml are no longer needed.

Changes

Removed from samples/pom.xml (69 lines):

  • maven-deploy-plugin with <skip>true</skip>
  • maven-install-plugin with <skip>true</skip>
  • maven-source-plugin with <phase>none</phase>
  • maven-javadoc-plugin with <skip>true</skip> and <phase>none</phase>
  • maven-gpg-plugin with <phase>none</phase>
  • nexus-staging-maven-plugin with <skipNexusStagingDeployMojo>true</skipNexusStagingDeployMojo>
  • central-publishing-maven-plugin with <skip>true</skip>

The effective exclusion is already handled by:

<!-- pom.xml line 258 -->
<arguments>-pl xapi-model,xapi-client,xapi-model-spring-boot-starter -am</arguments>
Original prompt

This section details on the original issue you should resolve

<issue_title>[Chore]: Clean up pom files to remove unnecessary ignore parameters for sample deployment</issue_title>
<issue_description>### What

Review and clean up all pom.xml files in the repository to remove experimental or unnecessary ignore parameters related to the deployment of sample modules. Recently, we achieved the prevention of samples being deployed with '-pl' and '-am' Maven switches, so old or failed attempts at ignoring these modules should be purged for clarity and maintainability.

Why

To prevent confusion for future contributors and maintainers, ensure clear and correct configuration in pom.xml files related to sample projects. Unsuccessful configurations should be removed to reduce technical debt and improve build reliability.

Notes

Check for any legacy ignore parameters that are left over from previous attempts. The samples should reliably NOT be deployed unless specified. Document any relevant findings in the commit message.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…/pom.xml

Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Copilot AI changed the title [WIP] Clean up pom files to remove unnecessary ignore parameters Remove redundant sample deployment skip configurations Nov 16, 2025
Copilot AI requested a review from thomasturrell November 16, 2025 08:02
@thomasturrell thomasturrell marked this pull request as ready for review November 16, 2025 08:11
@sonarqubecloud
Copy link

@thomasturrell thomasturrell merged commit 43deb4c into main Nov 16, 2025
6 checks passed
@thomasturrell thomasturrell deleted the copilot/clean-up-pom-files branch November 16, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore]: Clean up pom files to remove unnecessary ignore parameters for sample deployment

2 participants