Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 15, 2025

Description

The Maven release workflow fails when attempting to publish sample modules to Maven Central. The samples module has skip configurations for maven-deploy-plugin and maven-install-plugin, but the central-publishing-maven-plugin used by mvn release:perform requires its own explicit skip configuration.

Resolves #(issue)

Changes

Added central-publishing-maven-plugin skip configuration to samples/pom.xml:

<plugin>
  <groupId>org.sonatype.central</groupId>
  <artifactId>central-publishing-maven-plugin</artifactId>
  <configuration>
    <skip>true</skip>
  </configuration>
</plugin>

This complements existing skip configurations and ensures the release process only publishes production artifacts (xapi-model, xapi-client, xapi-model-spring-boot-starter).

Checklist:

  • Public methods are documented
  • Public methods are tested
  • New and existing tests pass when run locally
  • There are no new warnings or errors
Original prompt

This section details on the original issue you should resolve

<issue_title>[Chore]: Exclude sample modules from Maven release job in GitHub Actions</issue_title>
<issue_description>### What

Update the Maven release workflow in GitHub Actions to exclude sample modules from being published. This will prevent the release job from attempting to release unwanted modules and only publish intended artifacts.

Why

The release currently fails because it tries to publish sample modules, which are not meant to be released. Excluding these will ensure the release job succeeds and only production-ready modules are published, preventing unnecessary failures and confusion.

Notes

This change maintains a clean release process and avoids accidental publication of sample or example code. Review the workflow configuration or Maven pom files to implement the exclusion.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Maven release workflow to exclude sample modules Exclude sample modules from Maven Central release Nov 15, 2025
Copilot AI requested a review from thomasturrell November 15, 2025 20:57
@thomasturrell thomasturrell marked this pull request as ready for review November 15, 2025 20:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR resolves a Maven Central release failure by preventing sample modules from being published. The central-publishing-maven-plugin used during mvn release:perform requires explicit skip configuration, which was missing despite other deployment plugins already being configured to skip samples.

Key Changes:

  • Added central-publishing-maven-plugin skip configuration to the samples parent POM

@sonarqubecloud
Copy link

@thomasturrell
Copy link
Contributor

thomasturrell commented Nov 15, 2025

@copilot Have you tried a release dry run

@thomasturrell thomasturrell merged commit fcd83c5 into main Nov 15, 2025
12 checks passed
@thomasturrell thomasturrell deleted the copilot/exclude-sample-modules-release branch November 15, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore]: Exclude sample modules from Maven release job in GitHub Actions

2 participants